Skip to content

[fix][evaluation] expt itemretry idl tag#437

Merged
lsy357 merged 2 commits into
mainfrom
fix/evalexpt
Feb 27, 2026
Merged

[fix][evaluation] expt itemretry idl tag#437
lsy357 merged 2 commits into
mainfrom
fix/evalexpt

Conversation

@lsy357
Copy link
Copy Markdown
Collaborator

@lsy357 lsy357 commented Feb 27, 2026 •
edited
Loading

What type of PR is this?

feat

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

tpfz
tpfz previously approved these changes Feb 27, 2026
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ation/domain/service/expt_manage_execution_impl.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   72.88%   72.89%           
=======================================
  Files         624      624           
  Lines       62897    62897           
=======================================
+ Hits        45844    45848    +4     
+ Misses      13847    13845    -2     
+ Partials     3206     3204    -2
Flag Coverage Δ
unittests 72.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/domain/service/expt_manage_execution_impl.go 69.88% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caae357...2df2ff5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lsy357 lsy357 merged commit f1fffaa into main Feb 27, 2026
16 of 18 checks passed
@lsy357 lsy357 deleted the fix/evalexpt branch February 27, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpfz tpfz tpfz approved these changes

@dsf86 dsf86 dsf86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsy357 @tpfz @dsf86